Traits update #9554
Open
Traits update #9554
+49
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
MaxDesiatov
reviewed
Jan 3, 2026
Sources/PackageManagerDocs/Documentation.docc/Dependencies/PackageTraits.md
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jan 3, 2026
Sources/PackageManagerDocs/Documentation.docc/Dependencies/PackageTraits.md
Outdated
Show resolved
Hide resolved
… on a package with a trait as a new section. Switched up title to use a gerund phrase and the section headings to be imperative, and consistently sentence cased.
heckj
requested review from
bkhouri,
cmcgee1024,
daveyc123,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
FranzBusch
reviewed
Jan 14, 2026
| Enabled traits are exposed as conditional blocks (for example, `#if YourTrait`) that you can use to conditionally enable imports or different compilation paths in code. | ||
|
|
||
| ## Overview | ||
| Don't use the trait names `default` or `defaults` (regardless of capitalization) to avoid confusion with the default traits that a package defines. |
Member
There was a problem hiding this comment.
This sounds less strict than before. We do throw an error if one tries to use those names.
Sources/PackageManagerDocs/Documentation.docc/Dependencies/PackageTraits.md
Outdated
Show resolved
Hide resolved
…kageTraits.md Co-authored-by: Franz Busch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the traits documentation to touch on missed pieces and revise to conform a little better to developer content guidelines.
Motivation:
Modifications:
Grammar revisions and added sentences for clarity.